fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 07:28:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

i965/fs: Improve a comment about stripping trailing zeroes

Browse source 
Originally I wrote that removing the first parameter doesn't work but
I didn't know why. I now found a mention of this in the PRM so it's
probably worthing adding it to the comment.
This commit is contained in:
Neil Roberts 2015-05-08 16:13:52 +01:00
parent b004510072
commit f98c3f3e44
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/mesa/drivers/dri/i965/brw_fs.cpp
View file

@ -2600,9 +2600,12 @@ fs_visitor::opt_zero_samples()
load_payload->opcode != SHADER_OPCODE_LOAD_PAYLOAD)
continue;
/* We don't want to remove the message header. Removing all of the
* parameters is avoided because it seems to cause a GPU hang but I
* can't find any documentation indicating that this is expected.
/* We don't want to remove the message header or the first parameter.
* Removing the first parameter is not allowed, see the Haswell PRM
* volume 7, page 149:
*
* "Parameter 0 is required except for the sampleinfo message, which
* has no parameter 0"
*/
while (inst->mlen > inst->header_size + dispatch_width / 8 &&
load_payload->src[(inst->mlen - inst->header_size) /