fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-15 06:20:29 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

mesa/st: always use normalized coords for samplers

Browse source 
Normalized samplers is the norm, and non-normalized samplers might cause
some drivers and hardware to have to bend over backwards a bit.

We're using TXF here anyway, so it doesn't really matter what we set
this state to. So let's always use normalized samplers instead of
always using non-normalized samplers. That makes things easier for
everyone.

Fixes: e7b9561959 ("gallium: implement compute pbo download")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17708>
(cherry picked from commit 37733c100d)
This commit is contained in:
Erik Faye-Lund 2022-09-20 10:12:50 +02:00 • committed by Dylan Baker
parent 33ccf9ff92
commit f94eeaeb93
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1876,7 +1876,7 @@
"description": "mesa/st: always use normalized coords for samplers",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "e7b95619596167025d26f07efb04dc5bfd5e9aee"
},

1
src/mesa/state_tracker/st_pbo_compute.c
View file

@ -835,6 +835,7 @@ download_texture_compute(struct st_context *st,
struct pipe_sampler_view templ;
struct pipe_sampler_view *sampler_view;
struct pipe_sampler_state sampler = {0};
sampler.normalized_coords = true;
const struct pipe_sampler_state *samplers[1] = {&sampler};
const struct util_format_description *desc = util_format_description(dst_format);