fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 00:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

asahi: Fix race in BO stats accounting

Browse source 
These counters are accessed without locking, so they need to be atomic.
Should be cosmetic only.

Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24635>
This commit is contained in:
Asahi Lina 2023-07-22 18:34:11 +09:00 • committed by Marge Bot
parent 9762c55589
commit f8f4f466f7
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/asahi/lib/agx_bo.c
View file

@ -127,8 +127,9 @@ agx_bo_cache_put_locked(struct agx_bo *bo)
printf("BO cache: %zu KiB (+%zu KiB from %s, hit/miss %" PRIu64
"/%" PRIu64 ")\n",
DIV_ROUND_UP(dev->bo_cache.size, 1024),
DIV_ROUND_UP(bo->size, 1024), bo->label, dev->bo_cache.hits,
dev->bo_cache.misses);
DIV_ROUND_UP(bo->size, 1024), bo->label,
p_atomic_read(&dev->bo_cache.hits),
p_atomic_read(&dev->bo_cache.misses));
}
/* Update label for debug */
@ -224,9 +225,9 @@ agx_bo_create(struct agx_device *dev, unsigned size, enum agx_bo_flags flags,
/* Update stats based on the first attempt to fetch */
if (bo != NULL)
dev->bo_cache.hits++;
p_atomic_inc(&dev->bo_cache.hits);
else
dev->bo_cache.misses++;
p_atomic_inc(&dev->bo_cache.misses);
/* Otherwise, allocate a fresh BO. If allocation fails, we can try waiting
* for something in the cache. But if there's no nothing suitable, we should