From f6b5e128c13fe77199fb39f1b6e0a11504201352 Mon Sep 17 00:00:00 2001 From: SoroushIMG Date: Thu, 16 Feb 2023 09:43:40 +0000 Subject: [PATCH] zink: fix incorrect line mode check for bresenham the line requirement check logic was assuming mode index 0 is bresenhamLines, but it is actually rectangularLines. cc: mesa-stable Part-of: --- src/gallium/drivers/zink/zink_pipeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/zink/zink_pipeline.c b/src/gallium/drivers/zink/zink_pipeline.c index 0d61c397728..63d4e81c8bd 100644 --- a/src/gallium/drivers/zink/zink_pipeline.c +++ b/src/gallium/drivers/zink/zink_pipeline.c @@ -307,9 +307,9 @@ zink_create_gfx_pipeline(struct zink_screen *screen, /* non-strictLine default lines are either parallelogram or bresenham which while not in GL spec, * in practice end up being within the two-pixel exception in the GL spec. */ - else if (mode_idx || screen->info.props.limits.strictLines) + else if ((mode_idx != 1) || screen->info.props.limits.strictLines) warn_missing_feature(warned[mode_idx], features[hw_rast_state->line_mode][0]); - } else if (mode_idx || screen->info.props.limits.strictLines) + } else if ((mode_idx != 1) || screen->info.props.limits.strictLines) warn_missing_feature(warned[mode_idx], features[hw_rast_state->line_mode][hw_rast_state->line_stipple_enable]); }