fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 15:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/brw: Handle SHADER_OPCODE_SEND without src[3] in copy prop

Browse source 
We construct some SENDs with only 3 sources (such as FB writes).
This code could read out of bounds.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27876>
This commit is contained in:
Kenneth Graunke 2024-01-08 20:58:20 -08:00 • committed by Marge Bot
parent 49606ab067
commit f6ac6c94a9
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/intel/compiler/brw_fs_copy_propagation.cpp
View file

@ -698,7 +698,8 @@ try_copy_propagate(const brw_compiler *compiler, fs_inst *inst,
* We need to pin both split SEND sources in g112-g126/127, so only * We need to pin both split SEND sources in g112-g126/127, so only
* allow this if the registers aren't too large. * allow this if the registers aren't too large.
*/ */
if (inst->opcode == SHADER_OPCODE_SEND && entry->src.file == VGRF) { if (inst->opcode == SHADER_OPCODE_SEND && inst->sources >= 4 &&
entry->src.file == VGRF) {
int other_src = arg == 2 ? 3 : 2; int other_src = arg == 2 ? 3 : 2;
unsigned other_size = inst->src[other_src].file == VGRF ? unsigned other_size = inst->src[other_src].file == VGRF ?
alloc.sizes[inst->src[other_src].nr] : alloc.sizes[inst->src[other_src].nr] :