From f66b48d79090a794181d07bfd3c8ef85948e92da Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Wed, 14 Jan 2026 11:57:00 -0500 Subject: [PATCH] panvk/jm: Drop the loads_blend_const hack for uniform_count We already mark all fragment shaders as always using blend constants so this is handled by the existing code and our setting of push.count. Also, this hack is wrong as it pushes way too much and might overflow memory. Also, it will overflow the HW limit of 64 as soon as we increase the size of panvk_graphics_sysvals. Reviewed-by: Lars-Ivar Hesselberg Simonsen Part-of: --- src/panfrost/vulkan/jm/panvk_vX_cmd_draw.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/panfrost/vulkan/jm/panvk_vX_cmd_draw.c b/src/panfrost/vulkan/jm/panvk_vX_cmd_draw.c index e4ee3968863..0c04b58977d 100644 --- a/src/panfrost/vulkan/jm/panvk_vX_cmd_draw.c +++ b/src/panfrost/vulkan/jm/panvk_vX_cmd_draw.c @@ -289,15 +289,6 @@ panvk_draw_prepare_fs_rsd(struct panvk_cmd_buffer *cmdbuf, if (fs) { pan_shader_prepare_rsd(fs_info, fs_code, &cfg); - if (binfo->shader_loads_blend_const) { - /* Preload the blend constant if the blend shader depends on it. */ - cfg.preload.uniform_count = - MAX2(cfg.preload.uniform_count, - DIV_ROUND_UP(SYSVALS_PUSH_CONST_BASE + - sizeof(struct panvk_graphics_sysvals), - 8)); - } - uint8_t rt_mask = cmdbuf->state.gfx.render.bound_attachments & MESA_VK_RP_ATTACHMENT_ANY_COLOR_BITS; uint8_t rt_written = color_attachment_written_mask(