fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-31 07:40:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

glsl: Forbid opaque variables as operands of the ternary operator.

Browse source 
Reviewed-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
Francisco Jerez 2014-12-04 10:42:11 +02:00
parent b5854ee72b
commit f64edfdc44
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/glsl/ast_to_hir.cpp
View file

@ -1558,6 +1558,18 @@ ast_expression::do_hir(exec_list *instructions,
error_emitted = true;
}
/* From section 4.1.7 of the GLSL 4.50 spec (Opaque Types):
*
* "Except for array indexing, structure member selection, and
* parentheses, opaque variables are not allowed to be operands in
* expressions; such use results in a compile-time error."
*/
if (type->contains_opaque()) {
_mesa_glsl_error(&loc, state, "opaque variables cannot be operands "
"of the ?: operator");
error_emitted = true;
}
ir_constant *cond_val = op[0]->constant_expression_value();
if (then_instructions.is_empty()