fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 09:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

radeonsi/vcn: Change required FW version for rc_per_pic_ex on VCN3

Browse source 
It only works correctly on 29 and newer.
Also change the old FW message to one time warning.

Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12353
Reviewed-by: David (Ming Qiang) Wu <David.Wu3@amd.com>
(cherry picked from commit 2f76bdf35d)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32852>
This commit is contained in:
David Rosca 2024-12-29 10:13:23 +01:00 • committed by Dylan Baker
parent 789abcc23e
commit f63534c991
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -94,7 +94,7 @@
"description": "radeonsi/vcn: Change required FW version for rc_per_pic_ex on VCN3",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

2
src/gallium/drivers/radeonsi/radeon_vcn_enc.c
View file

@ -2007,7 +2007,7 @@ struct pipe_video_codec *radeon_create_encoder(struct pipe_context *context,
radeon_enc_4_0_init(enc);
}
else if (sscreen->info.vcn_ip_version >= VCN_3_0_0) {
if (sscreen->info.vcn_enc_minor_version >= 24)
if (sscreen->info.vcn_enc_minor_version >= 29)
enc->enc_pic.use_rc_per_pic_ex = true;
radeon_enc_3_0_init(enc);
}

4
src/gallium/drivers/radeonsi/radeon_vcn_enc_1_2.c
View file

@ -1175,8 +1175,8 @@ static void radeon_enc_intra_refresh(struct radeon_encoder *enc)
static void radeon_enc_rc_per_pic(struct radeon_encoder *enc)
{
fprintf(stderr, "Warning: Obsoleted rate control is being used due to outdated VCN firmware on system.\n");
fprintf(stderr, "Updating VCN firmware is highly recommended.\n");
debug_warn_once("Obsoleted rate control is being used due to outdated VCN firmware on system. "
"Updating VCN firmware is highly recommended.");
RADEON_ENC_BEGIN(enc->cmd.rc_per_pic);
RADEON_ENC_CS(enc->enc_pic.rc_per_pic.qp_obs);
RADEON_ENC_CS(enc->enc_pic.rc_per_pic.min_qp_app_obs);