diff --git a/.pick_status.json b/.pick_status.json index 37d8be420c9..e06472f5d1f 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1579,7 +1579,7 @@ "description": "winsys/amdgpu: don't read bo->u.slab.entry after pb_slab_free", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "965c6445ad419aa49302f75db1d99345708c5aae" }, diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 6cadfaa4313..ba98aa13075 100644 --- a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c @@ -666,22 +666,18 @@ static void amdgpu_bo_slab_destroy(struct radeon_winsys *rws, struct pb_buffer * { struct amdgpu_winsys *ws = amdgpu_winsys(rws); struct amdgpu_winsys_bo *bo = amdgpu_winsys_bo(_buf); + struct pb_slabs *slabs; assert(!bo->bo); - if (bo->base.usage & RADEON_FLAG_ENCRYPTED) - pb_slab_free(get_slabs(ws, - bo->base.size, - RADEON_FLAG_ENCRYPTED), &bo->u.slab.entry); - else - pb_slab_free(get_slabs(ws, - bo->base.size, - 0), &bo->u.slab.entry); + slabs = get_slabs(ws, bo->base.size, bo->base.usage & RADEON_FLAG_ENCRYPTED); if (bo->base.placement & RADEON_DOMAIN_VRAM) ws->slab_wasted_vram -= get_slab_wasted_size(ws, bo); else ws->slab_wasted_gtt -= get_slab_wasted_size(ws, bo); + + pb_slab_free(slabs, &bo->u.slab.entry); } static const struct pb_vtbl amdgpu_winsys_bo_slab_vtbl = {