From f572961d6937c0adceab39dd883cb53cfa965dc2 Mon Sep 17 00:00:00 2001 From: Konstantin Kharlamov Date: Wed, 10 Aug 2022 01:18:16 +0300 Subject: [PATCH] loader/dri3: simplify check for reply if reply == NULL, the call `free(reply)` is a no-op, so we can have a single check instead of two. Signed-off-by: Konstantin Kharlamov Reviewed-by: Emil Velikov . Part-of: --- src/loader/loader_dri3_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 89f0d8eaba1..6cae8eb7f1f 100644 --- a/src/loader/loader_dri3_helper.c +++ b/src/loader/loader_dri3_helper.c @@ -1239,10 +1239,8 @@ loader_dri3_open(xcb_connection_t *conn, provider); reply = xcb_dri3_open_reply(conn, cookie, NULL); - if (!reply) - return -1; - if (reply->nfd != 1) { + if (!reply || reply->nfd != 1) { free(reply); return -1; }