From f4eb833a12523142d908bf67e08904f4e8a866e9 Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Fri, 13 Mar 2020 16:07:26 +0000 Subject: [PATCH] nir/load_store_vectorize: don't ignore subgroup memory barriers Not sure why I thought this was correct, but we should consider them for optimization purposes. Fixes: ce9205c03bd ('nir: add a load/store vectorization pass') Signed-off-by: Rhys Perry Reviewed-by: Jason Ekstrand Part-of: --- src/compiler/nir/nir_opt_load_store_vectorize.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_load_store_vectorize.c b/src/compiler/nir/nir_opt_load_store_vectorize.c index e52006e40ef..41c968bfb25 100644 --- a/src/compiler/nir/nir_opt_load_store_vectorize.c +++ b/src/compiler/nir/nir_opt_load_store_vectorize.c @@ -1195,7 +1195,6 @@ handle_barrier(struct vectorize_ctx *ctx, bool *progress, nir_function_impl *imp release = nir_intrinsic_memory_semantics(intrin) & NIR_MEMORY_RELEASE; switch (nir_intrinsic_memory_scope(intrin)) { case NIR_SCOPE_INVOCATION: - case NIR_SCOPE_SUBGROUP: /* a barier should never be required for correctness with these scopes */ modes = 0; break;