From f3ee6ed43ca126d668f811ef490581fa94dcc047 Mon Sep 17 00:00:00 2001 From: Benjamin Lee Date: Fri, 21 Feb 2025 12:15:33 -0800 Subject: [PATCH] panfrost: fix condition in bi_nir_is_replicated The original implementation of this returned false when the src was replicated, and true when it was not. Signed-off-by: Benjamin Lee Fixes: 21bdee7bccd ("pan/bi: Switch to lower_bool_to_bitsize") Reviewed-by: Boris Brezillon Acked-by: Rebecca Mckeever Part-of: (cherry picked from commit 810351ad03e6d46bc8ab9e8c30843af00ed04d75) --- .pick_status.json | 2 +- src/panfrost/compiler/bifrost_compile.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index f56cf69db54..a950ee2738d 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -34,7 +34,7 @@ "description": "panfrost: fix condition in bi_nir_is_replicated", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "21bdee7bccd2b9b4b4f3b8b2eefce0466fc4b621", "notes": null diff --git a/src/panfrost/compiler/bifrost_compile.c b/src/panfrost/compiler/bifrost_compile.c index 81ae3c71beb..9e38c307eac 100644 --- a/src/panfrost/compiler/bifrost_compile.c +++ b/src/panfrost/compiler/bifrost_compile.c @@ -2475,7 +2475,7 @@ static bool bi_nir_is_replicated(nir_alu_src *src) { for (unsigned i = 1; i < nir_src_num_components(src->src); ++i) { - if (src->swizzle[0] == src->swizzle[i]) + if (src->swizzle[0] != src->swizzle[i]) return false; }