From f3db65d95ea59833fa5d29cf5ec3a669596d0a5e Mon Sep 17 00:00:00 2001 From: Nanley Chery Date: Mon, 24 Nov 2025 12:24:16 -0500 Subject: [PATCH] anv: Update predicated resolve documentation * Don't mention gfx7-8 due to the hasvk split. * Account for the array of clear colors. Fixes: 0e6b132a75e ("anv: Access more colors in fast_clear_memory_range") Reviewed-by: Jianxun Zhang Part-of: (cherry picked from commit e7854d06a59222d74219b76fa2ae2654a7062b8a) --- .pick_status.json | 2 +- src/intel/vulkan/anv_image.c | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index cc56793aebe..e0a637506bd 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -624,7 +624,7 @@ "description": "anv: Update predicated resolve documentation", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "0e6b132a75e6e7982155a001e4c51acb40e63f9a", "notes": null diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 35005811ff5..743bcc59291 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c @@ -554,10 +554,11 @@ anv_formats_ccs_e_compatible(const struct anv_physical_device *physical_device, * * The fast clear portion of the image is laid out in the following order: * - * * 1 or 4 dwords (depending on hardware generation) for the clear color + * * 1 clear color per view format used with the image (format depending on + * hardware generation). * * 1 dword for the anv_fast_clear_type of the clear color - * * On gfx9+, 1 dword per level and layer of the image (3D levels count - * multiple layers) in level-major order for compression state. + * * 1 dword per level and layer of the image (3D levels count multiple + * layers) in level-major order for compression state. * * For the purpose of discoverability, the algorithm used to manage * compression and fast-clears is described here: @@ -584,7 +585,7 @@ anv_formats_ccs_e_compatible(const struct anv_physical_device *physical_device, * See anv_layout_to_aux_usage and anv_layout_to_fast_clear_type functions for * details on exactly what is allowed in what layouts. * - * On gfx7-9, we do not have a concept of indirect clear colors in hardware. + * On gfx9, we do not have a concept of indirect clear colors in hardware. * In order to deal with this, we have to do some clear color management. * * * For LOAD_OP_LOAD at the top of a renderpass, we have to copy the clear