From f32dcb6fe17bdfb92ada00c28afc9d2b581ec1ca Mon Sep 17 00:00:00 2001 From: Filip Gawin Date: Thu, 16 Sep 2021 00:19:22 +0200 Subject: [PATCH] nir: assert that variables in optimize_atomic are initialized If you gonna view context of function parse_atomic_op, then you gonna know that index for array (data_src) can be unitialized. Imho this approach is cleaner than doing stuff inside parse_atomic_op. Reviewed-by: Emma Anholt Part-of: --- src/compiler/nir/nir_opt_uniform_atomics.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_uniform_atomics.c b/src/compiler/nir/nir_opt_uniform_atomics.c index 2c64e3198a4..cdd1319813a 100644 --- a/src/compiler/nir/nir_opt_uniform_atomics.c +++ b/src/compiler/nir/nir_opt_uniform_atomics.c @@ -194,7 +194,8 @@ reduce_data(nir_builder *b, nir_op op, nir_ssa_def *data, static nir_ssa_def * optimize_atomic(nir_builder *b, nir_intrinsic_instr *intrin, bool return_prev) { - unsigned offset_src, data_src; + unsigned offset_src = 0; + unsigned data_src = 0; nir_op op = parse_atomic_op(intrin->intrinsic, &offset_src, &data_src); nir_ssa_def *data = intrin->src[data_src].ssa;