fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-07 02:10:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

radv: add comment explaining why fp16 is disabled by default on gfx8

Browse source 
Suggested-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37442>
This commit is contained in:
Eric Engestrom 2025-09-18 10:23:01 +02:00 • committed by Marge Bot
parent 1ee1e63bdb
commit f2c4c5493e
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/amd/vulkan/radv_physical_device.c
View file

@ -877,6 +877,9 @@ radv_physical_device_get_features(const struct radv_physical_device *pdev, struc
.storagePushConstant8 = true,
.shaderBufferInt64Atomics = true,
.shaderSharedInt64Atomics = true,
/* GFX8 supports fp16, but not double rate packed math.
* We don't enable that by default because it can sometimes hurt perf.
*/
.shaderFloat16 = pdev->info.has_packed_math_16bit ||
(pdev->info.gfx_level == GFX8 && instance->drirc.features.expose_float16_gfx8),
.shaderInt8 = true,
@ -1470,6 +1473,9 @@ radv_get_physical_device_properties(struct radv_physical_device *pdev)
device_type = VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU;
}
/* GFX8 supports fp16, but not double rate packed math.
* We don't enable that by default because it can sometimes hurt perf.
*/
bool has_fp16 = pdev->info.has_packed_math_16bit ||
(pdev->info.gfx_level == GFX8 && instance->drirc.features.expose_float16_gfx8);