From f286451adaa2fcbf7bf6e4bf2f5b9c08d936c9fa Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Fri, 30 Sep 2022 10:59:15 -0700 Subject: [PATCH] intel/genxml: use a set for lookups Python will pre-compute the set since it's const, and the performance of a set search is significantly better than that of a list search Reviewd-by: Jordan Justen Part-of: --- src/intel/genxml/gen_sort_tags.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen_sort_tags.py b/src/intel/genxml/gen_sort_tags.py index bcb051dadf8..cab59f953fe 100755 --- a/src/intel/genxml/gen_sort_tags.py +++ b/src/intel/genxml/gen_sort_tags.py @@ -21,19 +21,19 @@ def get_start(element): return int(element.attrib['start'], 0) -base_types = [ +BASE_TYPES = { 'address', 'offset', 'int', 'uint', 'bool', 'float', -] +} FIXED_PATTERN = re.compile(r"(s|u)(\d+)\.(\d+)") def is_base_type(name): - return name in base_types or FIXED_PATTERN.match(name) + return name in BASE_TYPES or FIXED_PATTERN.match(name) def add_struct_refs(items, node): if node.tag == 'field':