From f256e8171cb47f5be566607dce5d6267324c550f Mon Sep 17 00:00:00 2001 From: Yiwei Zhang Date: Fri, 12 Jan 2024 14:38:59 -0800 Subject: [PATCH] venus: drop some redundant comment The render pass (legacy or dynamic) can be ignored only in a pipeline library with just Vertex Input State. For other cases, even when raster has been discarded, it is still needed at the api level to avoid violating a bunch of VUs which validate against attachments. The legacy pass byitself is also necessary to tell whether it's legacy or dynamic. So venus implemented at the VK api level should not drop render pass in those cases. The layout to be ref'ed is the one to be used, so we don't care about those being ignored, which has already been removed in the pipeline info fix. Signed-off-by: Yiwei Zhang Part-of: --- src/virtio/vulkan/vn_pipeline.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/virtio/vulkan/vn_pipeline.c b/src/virtio/vulkan/vn_pipeline.c index 58f5d394b80..e10576ff52f 100644 --- a/src/virtio/vulkan/vn_pipeline.c +++ b/src/virtio/vulkan/vn_pipeline.c @@ -848,10 +848,6 @@ vn_render_pass_state_update( * we don't read it, the host driver may read it. */ - /* XXX: Should this ignore the render pass for some state subsets when - * rasterization is statically disabled? The spec suggests "yes" and "no". - */ - /* VUID-VkGraphicsPipelineCreateInfo-flags-06643 * * If VkGraphicsPipelineLibraryCreateInfoEXT::flags includes @@ -1524,10 +1520,6 @@ vn_CreateGraphicsPipelines(VkDevice device, for (uint32_t i = 0; i < createInfoCount; i++) { struct vn_pipeline *pipeline = vn_pipeline_from_handle(pPipelines[i]); - - /* Grab a refcount on the pipeline layout when needed. Take care; the - * pipeline layout may be omitted or ignored in incomplete pipelines. - */ struct vn_pipeline_layout *layout = vn_pipeline_layout_from_handle(pCreateInfos[i].layout); if (layout && (layout->push_descriptor_set_layout ||