From f21dbfe5aebb9ecc30a8a576df43cfa06956f8cd Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Sun, 14 Apr 2024 13:12:45 -0400 Subject: [PATCH] agx: allow 8-bit bcsel can be generated from our lowerings but it just works with the implicit conversion semantics we have. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/asahi/compiler/agx_compile.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/asahi/compiler/agx_compile.c b/src/asahi/compiler/agx_compile.c index 165df8ad16f..b2e38e4a3a7 100644 --- a/src/asahi/compiler/agx_compile.c +++ b/src/asahi/compiler/agx_compile.c @@ -1590,11 +1590,11 @@ agx_emit_alu(agx_builder *b, nir_alu_instr *instr) ASSERTED unsigned comps = instr->def.num_components; assert(comps == 1 || nir_op_is_vec_or_mov(instr->op)); - assert( - sz == 1 || - ((nir_op_is_vec_or_mov(instr->op) || is_conversion_to_8bit(instr->op)) && - sz == 8) || - sz == 16 || sz == 32 || sz == 64); + assert(sz == 1 || + ((nir_op_is_vec_or_mov(instr->op) || + is_conversion_to_8bit(instr->op) || instr->op == nir_op_bcsel) && + sz == 8) || + sz == 16 || sz == 32 || sz == 64); agx_index dst = agx_def_index(&instr->def); agx_index s0 = srcs > 0 ? agx_alu_src_index(b, instr->src[0]) : agx_null();