intel/isl: Allow creating MCS in Tile4 memory

This enables MCS support on XeHP, now that MCS can be created with a
tiling supported by that platform.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Acked-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14464>
This commit is contained in:
Nanley Chery 2018-11-07 16:39:54 -08:00 committed by Marge Bot
parent f960e398d3
commit f1f65e5bcf
2 changed files with 8 additions and 4 deletions

View file

@ -828,8 +828,6 @@ isl_choose_image_alignment_el(const struct isl_device *dev,
{
const struct isl_format_layout *fmtl = isl_format_get_layout(info->format);
if (fmtl->txc == ISL_TXC_MCS) {
assert(tiling == ISL_TILING_Y0);
/*
* IvyBrigde PRM Vol 2, Part 1, "11.7 MCS Buffer for Render Target(s)":
*
@ -2084,7 +2082,7 @@ isl_surf_get_mcs_surf(const struct isl_device *dev,
.array_len = surf->logical_level0_px.array_len,
.samples = 1, /* MCS surfaces are really single-sampled */
.usage = ISL_SURF_USAGE_MCS_BIT,
.tiling_flags = ISL_TILING_Y0_BIT);
.tiling_flags = ISL_TILING_ANY_MASK);
}
bool
@ -2147,7 +2145,6 @@ isl_surf_supports_ccs(const struct isl_device *dev,
return false;
assert(mcs_surf->usage & ISL_SURF_USAGE_MCS_BIT);
assert(isl_tiling_is_any_y(mcs_surf->tiling));
assert(isl_format_is_mcs(mcs_surf->format));
} else {
/* Single-sampled color can't have MCS or HiZ */

View file

@ -54,6 +54,13 @@ isl_gfx125_filter_tiling(const struct isl_device *dev,
if (info->usage & ISL_SURF_USAGE_DISPLAY_BIT)
*flags &= ~ISL_TILING_64_BIT;
/* From RENDER_SURFACE_STATE::AuxiliarySurfaceMode,
*
* MCS tiling format is always Tile4
*/
if (info->usage & ISL_SURF_USAGE_MCS_BIT)
*flags &= ISL_TILING_4_BIT;
/* From RENDER_SURFACE_STATE::TileMode,
*
* TILEMODE_XMAJOR is only allowed if Surface Type is SURFTYPE_2D.