fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 15:38:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

v3d: only process glMemoryBarrier() for SSBOs and images

Browse source 
PIPE_BARRIER_UPDATE is defined as:
PIPE_BARRIER_UPDATE_BUFFER | PIPE_BARRIER_UPDATE_TEXTURE

Which means we were flushing for any flags other than these two, but
this was intended to only flush for ssbos and images.

Actually, the driver automatically flushes jobs as we need, including
writes/reads involving SSBOs and images, so we don't really need to
flush anything when the program emits a barrier. However, this may
lead to excessive flushing in some cases, so we will soon change this
to avoid atutomatic flushing of the current job for SSBOs and images,
meaning that we will rely on the application to emit correct memory
barriers for these that we should make sure to process here.

Reviewed-by: Eric Anholt <eric@anholt.net>
This commit is contained in:
Iago Toral Quiroga 2019-08-08 12:46:43 +02:00
parent f1559ca922
commit f1cf1153e8
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/gallium/drivers/v3d/v3d_context.c
View file

@ -72,7 +72,13 @@ v3d_memory_barrier(struct pipe_context *pctx, unsigned int flags)
{
struct v3d_context *v3d = v3d_context(pctx);
if (!(flags & ~PIPE_BARRIER_UPDATE))
/* We only need to flush for SSBOs and images, because for everything
* else we flush the job automatically when we needed.
*/
const unsigned int flush_flags = PIPE_BARRIER_SHADER_BUFFER |
PIPE_BARRIER_IMAGE;
if (!(flags & flush_flags))
return;
/* We only need to flush jobs writing to SSBOs/images. */