fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 02:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Factor out the point-sprite shader update logic

Browse source 
Not strictly needed for CSF, but anything we can do to make
panfrost_direct_draw() shorter is good to take.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26249>
This commit is contained in:
Boris Brezillon 2023-11-15 14:27:13 +01:00 • committed by Marge Bot
parent 782dc11791
commit f167e2facf
1 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
src/gallium/drivers/panfrost/pan_cmdstream.c
View file

@ -3557,6 +3557,25 @@ panfrost_increase_vertex_count(struct panfrost_batch *batch, uint32_t increment)
batch->tiler_ctx.vertex_count = UINT32_MAX;
}
/*
* If we change whether we're drawing points, or whether point sprites are
* enabled (specified in the rasterizer), we may need to rebind shaders
* accordingly. This implicitly covers the case of rebinding framebuffers,
* because all dirty flags are set there.
*/
static void
panfrost_update_point_sprite_shader(struct panfrost_context *ctx,
const struct pipe_draw_info *info)
{
if ((ctx->dirty & PAN_DIRTY_RASTERIZER) ||
((ctx->active_prim == MESA_PRIM_POINTS) ^
(info->mode == MESA_PRIM_POINTS))) {
ctx->active_prim = info->mode;
panfrost_update_shader_variant(ctx, PIPE_SHADER_FRAGMENT);
}
}
static void
panfrost_direct_draw(struct panfrost_batch *batch,
const struct pipe_draw_info *info, unsigned drawid_offset,
@ -3567,18 +3586,7 @@ panfrost_direct_draw(struct panfrost_batch *batch,
struct panfrost_context *ctx = batch->ctx;
/* If we change whether we're drawing points, or whether point sprites
* are enabled (specified in the rasterizer), we may need to rebind
* shaders accordingly. This implicitly covers the case of rebinding
* framebuffers, because all dirty flags are set there.
*/
if ((ctx->dirty & PAN_DIRTY_RASTERIZER) ||
((ctx->active_prim == MESA_PRIM_POINTS) ^
(info->mode == MESA_PRIM_POINTS))) {
ctx->active_prim = info->mode;
panfrost_update_shader_variant(ctx, PIPE_SHADER_FRAGMENT);
}
panfrost_update_point_sprite_shader(ctx, info);
/* Take into account a negative bias */
ctx->vertex_count =