intel/fs: QUAD_SWIZZLE requires packed data

We could probably support some strides if we tried hard enough but the
whole point of this opcode is to accelerate things with crazy Align16 or
crazy regions.  It's ok if we have to emit an extra MOV to get a packed
source.

Fixes: 8b4a5e641b "intel/fs: Add support for subgroup quad operations"
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7329>
(cherry picked from commit 58bcb5401d)
This commit is contained in:
Jason Ekstrand 2020-10-27 00:36:53 -05:00 committed by Dylan Baker
parent 92f23b657c
commit f155875446
2 changed files with 2 additions and 1 deletions

View file

@ -670,7 +670,7 @@
"description": "intel/fs: QUAD_SWIZZLE requires packed data",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "8b4a5e641bc3cb9cf0cfe7d0487926127fc25de7"
},

View file

@ -437,6 +437,7 @@ instruction_requires_packed_data(fs_inst *inst)
case FS_OPCODE_DDX_COARSE:
case FS_OPCODE_DDY_FINE:
case FS_OPCODE_DDY_COARSE:
case SHADER_OPCODE_QUAD_SWIZZLE:
return true;
default:
return false;