From f12f5ae2f8d4b394e31b3b39c3385f74a4abff86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20=C5=9Alusarz?= Date: Mon, 5 Jul 2021 15:48:03 +0200 Subject: [PATCH] anv: Add support for non-zero firstTask in vkCmdDrawMeshTasksNV MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Marcin Ślusarz Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/vulkan/genX_cmd_buffer.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index f5e39fced96..5b7e05ea60f 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -4857,12 +4857,15 @@ genX(CmdDrawMeshTasksNV)( if (cmd_buffer->state.conditional_render_enabled) genX(cmd_emit_conditional_render_predicate)(cmd_buffer); - /* TODO(mesh): Support non-zero firstTask. */ - assert(firstTask == 0); + /* BSpec 54016 says: "The values passed for Starting ThreadGroup ID X + * and ThreadGroup Count X shall not cause TGIDs to exceed (2^32)-1." + */ + assert((int64_t)firstTask + taskCount - 1 <= UINT32_MAX); anv_batch_emit(&cmd_buffer->batch, GENX(3DMESH_1D), m) { m.PredicateEnable = cmd_buffer->state.conditional_render_enabled; m.ThreadGroupCountX = taskCount; + m.StartingThreadGroupIDX = firstTask; } }