From f0c8645cb93bfb29771606b9a6aca4aa1a06d30e Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Mon, 9 Nov 2020 17:17:05 -0800 Subject: [PATCH] v3dv: Remove unsigned comparison to zero. index is of type uint32_t. Fix defects reported by Coverity Scan. Macro compares unsigned to 0 (NO_EFFECT) unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. index >= 0U. Signed-off-by: Vinson Lee Reviewed-by: Iago Toral Quiroga Part-of: --- src/broadcom/vulkan/v3dv_descriptor_set.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/broadcom/vulkan/v3dv_descriptor_set.c b/src/broadcom/vulkan/v3dv_descriptor_set.c index 89657ce5732..5cb7e964b41 100644 --- a/src/broadcom/vulkan/v3dv_descriptor_set.c +++ b/src/broadcom/vulkan/v3dv_descriptor_set.c @@ -130,7 +130,7 @@ v3dv_descriptor_map_get_descriptor_bo(struct v3dv_descriptor_state *descriptor_s uint32_t index, VkDescriptorType *out_type) { - assert(index >= 0 && index < map->num_desc); + assert(index < map->num_desc); uint32_t set_number = map->set[index]; assert(descriptor_state->valid & 1 << set_number); @@ -172,7 +172,7 @@ v3dv_descriptor_map_get_sampler(struct v3dv_descriptor_state *descriptor_state, struct v3dv_pipeline_layout *pipeline_layout, uint32_t index) { - assert(index >= 0 && index < map->num_desc); + assert(index < map->num_desc); uint32_t set_number = map->set[index]; assert(descriptor_state->valid & 1 << set_number);