From f0861645bb6ae68b906dce7eaa678a7af2bf6290 Mon Sep 17 00:00:00 2001 From: Leandro Ribeiro Date: Mon, 7 Aug 2023 23:06:50 -0300 Subject: [PATCH] egl: remove unused parameter from _eglAddDRMDevice() No callers are using the _EGLDevice **out_dev parameter which is being set by this function. So just drop it. Signed-off-by: Leandro Ribeiro Reviewed-by: Eric Engestrom Reviewed-by: Erik Faye-Lund Reviewed-by: Simon Ser Part-of: --- src/egl/main/egldevice.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/egl/main/egldevice.c b/src/egl/main/egldevice.c index b8fac582687..2678fcdfad8 100644 --- a/src/egl/main/egldevice.c +++ b/src/egl/main/egldevice.c @@ -108,7 +108,7 @@ _EGLDevice _eglSoftwareDevice = { * Negative value on error, zero if newly added, one if already in list. */ static int -_eglAddDRMDevice(drmDevicePtr device, _EGLDevice **out_dev) +_eglAddDRMDevice(drmDevicePtr device) { _EGLDevice *dev; @@ -126,19 +126,13 @@ _eglAddDRMDevice(drmDevicePtr device, _EGLDevice **out_dev) dev = dev->Next; assert(_eglDeviceSupports(dev, _EGL_DEVICE_DRM)); - if (drmDevicesEqual(device, dev->device) != 0) { - if (out_dev) - *out_dev = dev; + if (drmDevicesEqual(device, dev->device) != 0) return 1; - } } dev->Next = calloc(1, sizeof(_EGLDevice)); - if (!dev->Next) { - if (out_dev) - *out_dev = NULL; + if (!dev->Next) return -1; - } dev = dev->Next; dev->extensions = "EGL_EXT_device_drm"; @@ -151,9 +145,6 @@ _eglAddDRMDevice(drmDevicePtr device, _EGLDevice **out_dev) dev->EXT_device_drm_render_node = EGL_TRUE; } - if (out_dev) - *out_dev = dev; - return 0; } #endif @@ -314,7 +305,7 @@ _eglDeviceRefreshList(void) continue; } - ret = _eglAddDRMDevice(devices[i], NULL); + ret = _eglAddDRMDevice(devices[i]); /* Device is not added - error or already present */ if (ret != 0)