fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-27 01:50:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno/a6xx: Fix UB in convert_color()
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
Swizzle can include PIPE_SWIZZLE_0/_1 (4 and 5) which result in indexing
beyond the channel array.

Reported-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Fixes: 76e350671f ("freedreno/a6xx: Sysmem clear fixes")
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38593>
This commit is contained in:
Rob Clark 2025-11-22 09:02:23 -08:00 • committed by Marge Bot
parent 3eef0c0245
commit f0465ced7f
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/gallium/drivers/freedreno/a6xx/fd6_blitter.cc
View file

@ -867,6 +867,9 @@ convert_color(enum pipe_format format, union pipe_color_union *pcolor)
for (unsigned i = 0; i < 4; i++) {
unsigned channel = desc->swizzle[i];
if (channel >= 4) /* PIPE_SWIZZLE_0/_1 */
continue;
if (desc->channel[channel].normalized)
continue;