fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 06:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nvk: Validate push constant offset in nvk_root_descriptor_table
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
We requires this to be aligned to a 8 byte granuality.
This is something that came up with mesh shader enablement so let's
avoid this footgun with some assertion.

Signed-off-by: Mary Guillemard <mary@mary.zone>
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40407>
This commit is contained in:
Mary Guillemard 2026-02-12 17:01:43 +01:00 • committed by Marge Bot
parent 37d73fa4f3
commit ef8fd44b5f
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/nouveau/vulkan/nvk_cmd_buffer.h
View file

@ -70,6 +70,10 @@ struct nvk_root_descriptor_table {
#define nvk_root_descriptor_offset(member)\ #define nvk_root_descriptor_offset(member)\
offsetof(struct nvk_root_descriptor_table, member) offsetof(struct nvk_root_descriptor_table, member)
/* Push constants should be aligned properly */
static_assert(nvk_root_descriptor_offset(push) % 8 == 0,
"Push constants should be aligned properly");
enum ENUM_PACKED nvk_descriptor_set_type { enum ENUM_PACKED nvk_descriptor_set_type {
NVK_DESCRIPTOR_SET_TYPE_NONE, NVK_DESCRIPTOR_SET_TYPE_NONE,
NVK_DESCRIPTOR_SET_TYPE_SET, NVK_DESCRIPTOR_SET_TYPE_SET,