From eed6ae681c7fe771834d623819854dbe09a09764 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 11 Apr 2026 22:03:21 -0700 Subject: [PATCH] st/mesa: fix implicit conversion warning in st_atom_framebuffer ../src/mesa/state_tracker/st_atom_framebuffer.c:203:27: warning: implicit conversion from 'unsigned int' to 'uint8_t' (aka 'unsigned char') changes value from 4294967295 to 255 [-Wconstant-conversion] Fixes: 2b37f233143275d5d11fc0a5f392b8d99c7bad29 ("gallium: fix pipe_framebuffer_state::view_mask") Signed-off-by: Vinson Lee Reviewed-by: Mike Blumenkrantz Reviewed-by: Erik Faye-Lund (cherry picked from commit 27c870a28359644363547cdc0b18e36fc230e4ba) Part-of: --- .pick_status.json | 2 +- src/mesa/state_tracker/st_atom_framebuffer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 859060a1e50..0d8176c0dc9 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -734,7 +734,7 @@ "description": "st/mesa: fix implicit conversion warning in st_atom_framebuffer", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "2b37f233143275d5d11fc0a5f392b8d99c7bad29", "notes": null diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c b/src/mesa/state_tracker/st_atom_framebuffer.c index 08ed3d2b454..cc5ad3d3cb7 100644 --- a/src/mesa/state_tracker/st_atom_framebuffer.c +++ b/src/mesa/state_tracker/st_atom_framebuffer.c @@ -200,7 +200,7 @@ st_update_framebuffer_state( struct st_context *st ) memset(&framebuffer.zsbuf, 0, sizeof(framebuffer.zsbuf)); } - framebuffer.viewmask = BITFIELD_MASK(num_multiview_layer); + framebuffer.viewmask = (uint8_t)BITFIELD_MASK(num_multiview_layer); #ifndef NDEBUG /* Make sure the resource binding flags were set properly */