fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 04:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

radv: do not enable DCC for MSAA images without FMASK

Browse source 
I don't know how this is supposed to work, especially for fast clears
because CMASK should be cleared to 0xC but FMASK implies CMASK.
This fixes a bunch of MSAA test failures on GFX10.3 with
RADV_DEBUG=nofmask.

Cc: 22.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20054>
(cherry picked from commit 84a7138d3c)
This commit is contained in:
Samuel Pitoiset 2022-11-29 08:34:24 +01:00 • committed by Eric Engestrom
parent 488f186c2a
commit ed0cb79072
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -130,7 +130,7 @@
"description": "radv: do not enable DCC for MSAA images without FMASK",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

4
src/amd/vulkan/radv_image.c
View file

@ -281,6 +281,10 @@ radv_use_dcc_for_image_early(struct radv_device *device, struct radv_image *imag
return false;
}
/* FIXME: Figure out how to use DCC for MSAA images without FMASK. */
if (pCreateInfo->samples > 1 && !device->physical_device->use_fmask)
return false;
return radv_are_formats_dcc_compatible(device->physical_device, pCreateInfo->pNext, format,
pCreateInfo->flags, sign_reinterpret);
}