fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 22:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

mesa/st: Reduce the number of frontbuffer flush calls

Browse source 
The mesa state tracker was needlessly flushing the front buffer even if it
hadn't been drawn to since the last flush. This was happening during
glXSwapBuffers if we at some point previously had set that frontbuffer as
a read- or draw renderbuffer, or at glFlush() or glFinish() if we at some
point previously had rendered to the front buffer. Since the frontbuffer
flush typically means a full drawable copy, it's a pretty big waste.

Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
This commit is contained in:
Thomas Hellstrom 2017-06-20 21:12:50 +02:00
parent eb88ece9e3
commit eceb671002
2 changed files with 10 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
src/mesa/state_tracker/st_cb_flush.c
View file

@ -46,35 +46,6 @@
#include "util/u_gen_mipmap.h"
/** Check if we have a front color buffer and if it's been drawn to. */
static inline GLboolean
is_front_buffer_dirty(struct st_context *st)
{
struct gl_framebuffer *fb = st->ctx->DrawBuffer;
struct st_renderbuffer *strb
= st_renderbuffer(fb->Attachment[BUFFER_FRONT_LEFT].Renderbuffer);
return strb && strb->defined;
}
/**
* Tell the screen to display the front color buffer on-screen.
*/
static void
display_front_buffer(struct st_context *st)
{
struct gl_framebuffer *fb = st->ctx->DrawBuffer;
struct st_renderbuffer *strb
= st_renderbuffer(fb->Attachment[BUFFER_FRONT_LEFT].Renderbuffer);
if (strb) {
/* Hook for copying "fake" frontbuffer if necessary:
*/
st_manager_flush_frontbuffer(st);
}
}
void st_flush(struct st_context *st,
struct pipe_fence_handle **fence,
unsigned flags)
@ -120,9 +91,7 @@ static void st_glFlush(struct gl_context *ctx)
*/
st_flush(st, NULL, 0);
if (is_front_buffer_dirty(st)) {
display_front_buffer(st);
}
st_manager_flush_frontbuffer(st);
}
@ -135,9 +104,7 @@ static void st_glFinish(struct gl_context *ctx)
st_finish(st);
if (is_front_buffer_dirty(st)) {
display_front_buffer(st);
}
st_manager_flush_frontbuffer(st);
}

12
src/mesa/state_tracker/st_manager.c
View file

@ -1036,11 +1036,15 @@ st_manager_flush_frontbuffer(struct st_context *st)
if (stfb)
strb = st_renderbuffer(stfb->Base.Attachment[BUFFER_FRONT_LEFT].Renderbuffer);
if (!strb)
return;
/* never a dummy fb */
stfb->iface->flush_front(&st->iface, stfb->iface, ST_ATTACHMENT_FRONT_LEFT);
/* Do we have a front color buffer and has it been drawn to since last
* frontbuffer flush?
*/
if (strb && strb->defined) {
stfb->iface->flush_front(&st->iface, stfb->iface,
ST_ATTACHMENT_FRONT_LEFT);
strb->defined = GL_FALSE;
}
}
/**