fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 21:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

glsl: reject bindless samplers/images frag inputs without 'flat'

Browse source 
From section 4.3.4 of the ARB_bindless_texture spec

   "(modify last paragraph, p. 35, allowing samplers and images as
    fragment shader inputs) ... Fragment inputs can only be signed
    and unsigned integers and integer vectors, floating point scalars,
    floating-point vectors, matrices, sampler and image types, or
    arrays or structures of these.  Fragment shader inputs that are
    signed or unsigned integers, integer vectors, or any
    double-precision floating- point type, or any sampler or image
    type must be qualified with the interpolation qualifier "flat"."

v3: - update spec comment formatting

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
This commit is contained in:
Samuel Pitoiset 2017-03-22 18:34:23 +01:00
parent 8834c74fef
commit ece1c04e8e
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/compiler/glsl/ast_to_hir.cpp
View file

@ -2996,6 +2996,26 @@ validate_fragment_flat_interpolation_input(struct _mesa_glsl_parse_state *state,
_mesa_glsl_error(loc, state, "if a fragment input is (or contains) "
"a double, then it must be qualified with 'flat'");
}
/* Bindless sampler/image fragment inputs must be qualified with 'flat'.
*
* From section 4.3.4 of the ARB_bindless_texture spec:
*
* "(modify last paragraph, p. 35, allowing samplers and images as
* fragment shader inputs) ... Fragment inputs can only be signed and
* unsigned integers and integer vectors, floating point scalars,
* floating-point vectors, matrices, sampler and image types, or arrays
* or structures of these. Fragment shader inputs that are signed or
* unsigned integers, integer vectors, or any double-precision floating-
* point type, or any sampler or image type must be qualified with the
* interpolation qualifier "flat"."
*/
if (state->has_bindless()
&& (var_type->contains_sampler() || var_type->contains_image())) {
_mesa_glsl_error(loc, state, "if a fragment input is (or contains) "
"a bindless sampler (or image), then it must be "
"qualified with 'flat'");
}
}
static void