From ec57edb3de0899cc9bc06d2dcb1cb3edc282987f Mon Sep 17 00:00:00 2001 From: Icenowy Zheng Date: Tue, 25 Nov 2025 17:39:59 +0800 Subject: [PATCH] pvr: enable samplerMirrorClampToEdge feature This is forgotten when advertising the corresponding extension, which leads to inconsistency, thus fail of dEQP-VK.api.info.vulkan1p2.feature_extensions_consistency CTS testcase. Enable the corresponding feature too. I ran all CTS tests with "mirror_clamp_to_edge" in name, which are all skipped with NotSupported before (because of the feature being not advertised), and gain 3695/11140 Pass with the remaining ones still NotSupported (no Fail). This also makes the feature extension consistency CTS testcase Pass too. Fixes: 4d34c07b7a9f ("pvr: advertise VK_KHR_sampler_mirror_clamp_to_edge") Signed-off-by: Icenowy Zheng Reviewed-by: Frank Binns Part-of: (cherry picked from commit ab9e148bfb10c1a442741a23ea4afe09226fa520) Conflicts: src/imagination/vulkan/pvr_physical_device.c (File has been renamed since branchpoint) --- .pick_status.json | 2 +- src/imagination/vulkan/pvr_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 7c06b360094..a8b778d635b 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -2414,7 +2414,7 @@ "description": "pvr: enable samplerMirrorClampToEdge feature", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "4d34c07b7a9f58e92061844a378ceaf2f737c27a", "notes": null diff --git a/src/imagination/vulkan/pvr_device.c b/src/imagination/vulkan/pvr_device.c index bfb499ab2d8..f7f84c6db33 100644 --- a/src/imagination/vulkan/pvr_device.c +++ b/src/imagination/vulkan/pvr_device.c @@ -322,7 +322,7 @@ static void pvr_physical_device_get_supported_features( .samplerYcbcrConversion = false, /* Vulkan 1.2 */ - .samplerMirrorClampToEdge = false, + .samplerMirrorClampToEdge = true, .drawIndirectCount = false, .storageBuffer8BitAccess = false, .uniformAndStorageBuffer8BitAccess = false,