fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 11:28:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

tgsi: Fixes ntt_should_vectorize_io parameters

Browse source 
Fixes: 5f757bb95c ("nir: Make the load_store_vectorizer provide align_mul + align_offset.")

This is found when I am trying to narrow bit_size and num_components to uint8_t

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37042>
(cherry picked from commit 949a056934)
This commit is contained in:
Yonggang Luo 2025-08-28 14:38:17 +08:00 • committed by Eric Engestrom
parent 677f1c4541
commit ec27b06cf6
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -9744,7 +9744,7 @@
"description": "tgsi: Fixes ntt_should_vectorize_io parameters",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "5f757bb95c20cdebed578b851e9f204b8aa6c014",
"notes": null

9
src/gallium/auxiliary/nir/nir_to_tgsi.c
View file

@ -3267,14 +3267,17 @@ ntt_should_vectorize_instr(const nir_instr *instr, const void *data)
return 4;
}
/* TODO: These parameters are wrong. */
static bool
ntt_should_vectorize_io(unsigned align, unsigned bit_size,
unsigned num_components, unsigned high_offset,
ntt_should_vectorize_io(unsigned align_mul,
unsigned align_offset,
unsigned bit_size,
unsigned num_components,
int64_t hole_size,
nir_intrinsic_instr *low, nir_intrinsic_instr *high,
void *data)
{
const uint32_t align = nir_combined_align(align_mul, align_offset);
if (bit_size != 32 || hole_size > 0 || !nir_num_components_valid(num_components))
return false;