fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-24 19:00:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

anv/lower_input_attachments: honor sample index parameter to subpassLoad()

Browse source 
According to GL_KHR_vulkan_glsl, the signature of subpassLoad() is:

gvec4 subpassLoad(gsubpassInput   subpass);
gvec4 subpassLoad(gsubpassInputMS subpass, int sample);

So the multisampled case always receives an explicit sample index that we
should use. The current implementation was ignoring this parameter
and using gl_SampleID value instead.

Fixes:
dEQP-VK.pipeline.multisample_shader_builtin.sample_id.*

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Cc: "17.0" <mesa-stable@lists.freedesktop.org>
(cherry picked from commit 9b25769da6)
This commit is contained in:
Iago Toral Quiroga 2017-01-25 15:04:35 +01:00 • committed by Emil Velikov
parent dcb3b24b86
commit ebfe5e17ee
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/intel/vulkan/anv_nir_lower_input_attachments.c
View file

@ -100,11 +100,8 @@ try_lower_input_load(nir_function_impl *impl, nir_intrinsic_instr *load)
if (image_dim == GLSL_SAMPLER_DIM_SUBPASS_MS) {
tex->op = nir_texop_txf_ms;
nir_ssa_def *sample_id =
nir_load_system_value(&b, nir_intrinsic_load_sample_id, 0);
tex->src[2].src_type = nir_tex_src_ms_index;
tex->src[2].src = nir_src_for_ssa(sample_id);
tex->src[2].src = load->src[1];
}
nir_ssa_dest_init(&tex->instr, &tex->dest, 4, 32, NULL);