fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 06:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

zink: Check for VK_EXT_extended_dynamic_state3 before setting A2C

Browse source 
Fix crashes for piglit alpha-to-coverage tests when
VK_EXT_extended_dynamic_state3 is not supported (like on Venus)

Fixes: 736577871b ("zink: check for cbuf0 writes before setting A2C")

Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Antonino Maniscalco <antonino.maniscalco@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26003>
(cherry picked from commit fe159c85de)
This commit is contained in:
Mary Guillemard 2023-11-02 06:37:31 -04:00 • committed by Eric Engestrom
parent 3902e9302d
commit eb9f7db980
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -164,7 +164,7 @@
"description": "zink: Check for VK_EXT_extended_dynamic_state3 before setting A2C",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "736577871b939573af400e4e64ebfe18863d49af",
"notes": null

3
src/gallium/drivers/zink/zink_program.c
View file

@ -1871,7 +1871,8 @@ zink_bind_fs_state(struct pipe_context *pctx,
if (cso) {
shader_info *info = &ctx->gfx_stages[MESA_SHADER_FRAGMENT]->info;
bool new_writes_cbuf0 = (info->outputs_written & BITFIELD_BIT(FRAG_RESULT_DATA0)) > 0;
if (ctx->gfx_pipeline_state.blend_state && ctx->gfx_pipeline_state.blend_state->alpha_to_coverage && writes_cbuf0 != new_writes_cbuf0) {
if (ctx->gfx_pipeline_state.blend_state && ctx->gfx_pipeline_state.blend_state->alpha_to_coverage &&
writes_cbuf0 != new_writes_cbuf0 && zink_screen(pctx->screen)->info.have_EXT_extended_dynamic_state3) {
ctx->blend_state_changed = true;
ctx->ds3_states |= BITFIELD_BIT(ZINK_DS3_BLEND_A2C);
}