diff --git a/.pick_status.json b/.pick_status.json index f37e175c3d9..00e277f83c8 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1664,7 +1664,7 @@ "description": "lavapipe: fix pushconst data updating", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/gallium/frontends/lavapipe/lvp_execute.c b/src/gallium/frontends/lavapipe/lvp_execute.c index ebc97a3c2c3..a718d1e0d25 100644 --- a/src/gallium/frontends/lavapipe/lvp_execute.c +++ b/src/gallium/frontends/lavapipe/lvp_execute.c @@ -332,7 +332,7 @@ update_pcbuf(struct rendering_state *state, mesa_shader_stage pstage, static void emit_compute_state(struct rendering_state *state) { - if (state->pcbuf_dirty[MESA_SHADER_COMPUTE]) + if (state->pcbuf_dirty[MESA_SHADER_COMPUTE] && state->has_pcbuf[MESA_SHADER_COMPUTE]) update_pcbuf(state, MESA_SHADER_COMPUTE, MESA_SHADER_COMPUTE); if (state->constbuf_dirty[MESA_SHADER_COMPUTE]) { @@ -638,9 +638,6 @@ handle_compute_shader(struct rendering_state *state, struct lvp_shader *shader) state->has_pcbuf[MESA_SHADER_COMPUTE] = shader->push_constant_size > 0; - if (!state->has_pcbuf[MESA_SHADER_COMPUTE]) - state->pcbuf_dirty[MESA_SHADER_COMPUTE] = false; - state->dispatch_info.block[0] = shader->pipeline_nir->nir->info.workgroup_size[0]; state->dispatch_info.block[1] = shader->pipeline_nir->nir->info.workgroup_size[1]; state->dispatch_info.block[2] = shader->pipeline_nir->nir->info.workgroup_size[2];