fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-25 16:58:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir: fix documentation for uadd_carry and usub_borry opcodes

Browse source 
These opcodes where fixed to return an integer instead of a boolean
value some time ago but the documentation for them was not updated
and still talked about a boolean result.

Fixes: b0d4ee520 ('nir/opcodes: Fix up uadd_carry and usub_borrow')
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17372>
(cherry picked from commit 84a0dca9df)
This commit is contained in:
Iago Toral Quiroga 2022-07-07 11:13:51 +02:00 • committed by Dylan Baker
parent 0fec632102
commit eb1fb9305d
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2182,7 +2182,7 @@
"description": "nir: fix documentation for uadd_carry and usub_borry opcodes",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "b0d4ee520e20444172d088d11260e656fc1cf12d"
},

8
src/compiler/nir/nir_opcodes.py
View file

@ -762,13 +762,13 @@ binop("fdiv", tfloat, "", "src0 / src1")
binop("idiv", tint, "", "src1 == 0 ? 0 : (src0 / src1)")
binop("udiv", tuint, "", "src1 == 0 ? 0 : (src0 / src1)")
# returns a boolean representing the carry resulting from the addition of
# the two unsigned arguments.
# returns an integer (1 or 0) representing the carry resulting from the
# addition of the two unsigned arguments.
binop_convert("uadd_carry", tuint, tuint, _2src_commutative, "src0 + src1 < src0")
# returns a boolean representing the borrow resulting from the subtraction
# of the two unsigned arguments.
# returns an integer (1 or 0) representing the borrow resulting from the
# subtraction of the two unsigned arguments.
binop_convert("usub_borrow", tuint, tuint, "", "src0 < src1")