fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 19:40:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Add an allow_rotating_primitives() helper

Browse source 
Factor out the logic so we can use the helper when adding CSF support.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26249>
This commit is contained in:
Alyssa Rosenzweig 2023-11-15 11:02:49 +01:00 • committed by Marge Bot
parent e81f99134e
commit ea72a0bec6
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/gallium/drivers/panfrost/pan_cmdstream.c
View file

@ -2998,6 +2998,14 @@ panfrost_batch_get_bifrost_tiler(struct panfrost_batch *batch,
}
#endif
static bool
allow_rotating_primitives(const struct panfrost_compiled_shader *fs,
const struct pipe_draw_info *info)
{
return u_reduced_prim(info->mode) != MESA_PRIM_LINES &&
!fs->info.bifrost.uses_flat_shading;
}
/* Packs a primitive descriptor, mostly common between Midgard/Bifrost tiler
* jobs and Valhall IDVS jobs
*/
@ -3010,8 +3018,6 @@ panfrost_emit_primitive(struct panfrost_batch *batch,
struct panfrost_context *ctx = batch->ctx;
UNUSED struct pipe_rasterizer_state *rast = &ctx->rasterizer->base;
bool lines = u_reduced_prim(info->mode) == MESA_PRIM_LINES;
pan_pack(out, PRIMITIVE, cfg) {
cfg.draw_mode = pan_draw_mode(info->mode);
if (panfrost_writes_point_size(ctx))
@ -3022,7 +3028,7 @@ panfrost_emit_primitive(struct panfrost_batch *batch,
* be set to true and the provoking vertex is selected with
* DRAW.flat_shading_vertex.
*/
if (lines)
if (u_reduced_prim(info->mode) == MESA_PRIM_LINES)
cfg.first_provoking_vertex = true;
else
cfg.first_provoking_vertex = rast->flatshade_first;
@ -3038,8 +3044,7 @@ panfrost_emit_primitive(struct panfrost_batch *batch,
#else
struct panfrost_compiled_shader *fs = ctx->prog[PIPE_SHADER_FRAGMENT];
cfg.allow_rotating_primitives =
!(lines || fs->info.bifrost.uses_flat_shading);
cfg.allow_rotating_primitives = allow_rotating_primitives(fs, info);
cfg.primitive_restart = info->primitive_restart;
/* Non-fixed restart indices should have been lowered */