fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-04 09:10:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir/opt_copy_prop_vars: don't clone copies if branch empty

Browse source 
There is no point doing an expensive clone of the copies if the
if-branch is empty.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24227>
This commit is contained in:
Timothy Arceri 2023-07-11 13:21:57 +10:00 • committed by Marge Bot
parent 527cc3ad29
commit e9804bdc4c
1 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/compiler/nir/nir_opt_copy_prop_vars.c
View file

@ -1383,21 +1383,25 @@ copy_prop_vars_cf_node(struct copy_prop_var_state *state,
* that they both see the same state of available copies, but do not
* interfere to each other.
*/
struct copies *then_copies = get_copies_structure(state);
clone_copies(state, then_copies, copies);
if (!exec_list_is_empty(&if_stmt->then_list)) {
struct copies *then_copies = get_copies_structure(state);
clone_copies(state, then_copies, copies);
foreach_list_typed_safe(nir_cf_node, cf_node, node, &if_stmt->then_list)
copy_prop_vars_cf_node(state, then_copies, cf_node);
foreach_list_typed_safe(nir_cf_node, cf_node, node, &if_stmt->then_list)
copy_prop_vars_cf_node(state, then_copies, cf_node);
clear_copies_structure(state, then_copies);
clear_copies_structure(state, then_copies);
}
struct copies *else_copies = get_copies_structure(state);
clone_copies(state, else_copies, copies);
if (!exec_list_is_empty(&if_stmt->else_list)) {
struct copies *else_copies = get_copies_structure(state);
clone_copies(state, else_copies, copies);
foreach_list_typed_safe(nir_cf_node, cf_node, node, &if_stmt->else_list)
copy_prop_vars_cf_node(state, else_copies, cf_node);
foreach_list_typed_safe(nir_cf_node, cf_node, node, &if_stmt->else_list)
copy_prop_vars_cf_node(state, else_copies, cf_node);
clear_copies_structure(state, else_copies);
clear_copies_structure(state, else_copies);
}
/* Both branches copies can be ignored, since the effect of running both
* branches was captured in the first pass that collects vars_written.