fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-29 08:00:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

anv: ensure null-rt bit in compiler isn't used when there is ds attachment

Browse source 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 15987f49bb ("anv: avoid setting up a null RT unless needed")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12396
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
(cherry picked from commit 98cdb9349a)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33113>
This commit is contained in:
Lionel Landwerlin 2025-01-03 16:36:16 +02:00 • committed by Dylan Baker
parent 17381f3190
commit e8fdb9fe5c
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -204,7 +204,7 @@
"description": "anv: ensure null-rt bit in compiler isn't used when there is ds attachment",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "15987f49bb9ca105f7b252d90349f614c492c3d5",
"notes": null

9
src/intel/vulkan/anv_pipeline.c
View file

@ -531,6 +531,15 @@ rp_color_mask(const struct vk_render_pass_state *rp)
color_mask |= BITFIELD_BIT(i);
}
/* If there is depth/stencil attachment, even if the fragment shader
* doesn't write the depth/stencil output, we need a valid render target so
* that the compiler doesn't use the null-rt which would cull the
* depth/stencil output.
*/
if (rp->depth_attachment_format != VK_FORMAT_UNDEFINED ||
rp->stencil_attachment_format != VK_FORMAT_UNDEFINED)
color_mask |= 1;
return color_mask;
}