fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 07:18:17 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv/bvh: Prevent NANs when computing node cost

Browse source 
Otherwise the degenerate geometry workaround never triggers, leading to bad performance.

Fixes: 6f45c98b ("radv/bvh: Adjust sah cost based on depth")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20723>
(cherry picked from commit 684eee0748)
This commit is contained in:
Friedrich Vock 2023-01-16 11:14:44 +01:00 • committed by Dylan Baker
parent 20f8f6ebc6
commit e8dd7a275e
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -625,7 +625,7 @@
"description": "radv/bvh: Prevent NANs when computing node cost",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "6f45c98b580de5a534ebb0a0644ac5514793a141"
},

3
src/amd/vulkan/bvh/ploc_internal.comp
View file

@ -198,6 +198,9 @@ combined_node_cost(uint32_t lds_base, uint32_t i, uint32_t j)
combined_bounds.max = max(shared_bounds[i - lds_base].max, shared_bounds[j - lds_base].max);
float area = aabb_surface_area(combined_bounds);
if (area == 0.0)
return 0.0;
/* p_a and p_b are the probabilities that i or j are hit by a ray:
* Assuming that the current node is hit (p = 1) and the probability of hitting a node
* is proportional to its surface area, p = area * c with p = 1 for the current node.