fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 21:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ir3: use lower_image_samples_to_one

Browse source 
This is necessary to properly support ARB_shader_texture_image_samples
fixes crash in KHR-GL45.shader_texture_image_samples_tests.image_functional_test

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Rob Clark <robclark@freedesktop.org>
Reviewer-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: Amber Amber <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20813>
This commit is contained in:
Amber 2023-01-24 11:38:17 +01:00 • committed by Marge Bot
parent c384690ab7
commit e8bfb71660
3 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/freedreno/ci/freedreno-a618-fails.txt
View file

@ -39,10 +39,6 @@ KHR-GL45.direct_state_access.renderbuffers_storage_multisample,Fail
KHR-GL45.multi_bind.dispatch_bind_image_textures,Fail
# Unhandled intrinsic type: image_samples
KHR-GL45.shader_texture_image_samples_tests.image_functional_test,Crash
# rendering errors in ~4x4 blocks around the bottom side of the diagonal for the quad
bypass-dEQP-GLES31.functional.blend_equation_advanced.msaa.colorburn,Fail
bypass-dEQP-GLES31.functional.blend_equation_advanced.msaa.colordodge,Fail

4
src/freedreno/ci/freedreno-a630-fails.txt
View file

@ -38,10 +38,6 @@ KHR-GL45.direct_state_access.renderbuffers_storage_multisample,Fail
KHR-GL45.multi_bind.dispatch_bind_image_textures,Fail
# Unhandled intrinsic type: image_samples
KHR-GL45.shader_texture_image_samples_tests.image_functional_test,Crash
# rendering errors in ~4x4 blocks around the bottom side of the diagonal for the quad
bypass-dEQP-GLES31.functional.blend_equation_advanced.msaa.colorburn,Fail
bypass-dEQP-GLES31.functional.blend_equation_advanced.msaa.colordodge,Fail

1
src/freedreno/ir3/ir3_nir.c
View file

@ -582,6 +582,7 @@ ir3_nir_post_finalize(struct ir3_shader *shader)
const nir_lower_image_options lower_image_opts = {
.lower_cube_size = true,
.lower_image_samples_to_one = true
};
NIR_PASS_V(s, nir_lower_image, &lower_image_opts);