From e82e72b5b78a09c7413380de86e83a72bc6be825 Mon Sep 17 00:00:00 2001 From: Mary Guillemard Date: Tue, 15 Apr 2025 17:12:29 +0200 Subject: [PATCH] panvk: Fix inverted ZS read flags in DCD2 on v11+ Those flags are negative so it should have been the opposite (no read) Fixes: 9b4886d6f490 ("panvk: Implement Z/S dependency tracking on v11+") Signed-off-by: Mary Guillemard Reported-by: Daniel Stone Reviewed-by: Boris Brezillon Reviewed-by: Daniel Stone Part-of: --- src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c index 14dd495cb15..ff45e337a15 100644 --- a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c +++ b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c @@ -1741,8 +1741,8 @@ prepare_dcd(struct panvk_cmd_buffer *cmdbuf, cfg.write_mask = rt_written; #if PAN_ARCH >= 11 if (fs) { - cfg.no_shader_depth_read = z_attachment_read(fs, &dyns->ial); - cfg.no_shader_stencil_read = s_attachment_read(fs, &dyns->ial); + cfg.no_shader_depth_read = !z_attachment_read(fs, &dyns->ial); + cfg.no_shader_stencil_read = !s_attachment_read(fs, &dyns->ial); } #endif }