fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 00:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir/validate: Assert txf(_ms) matches dimension

Browse source 
We can't txf_ms on non-MS images and we can't txf on MS images. This would have
caught a regression on Asahi.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23892>
This commit is contained in:
Alyssa Rosenzweig 2023-06-27 14:01:58 -04:00 • committed by Marge Bot
parent 5099137612
commit e81b5b972e
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/compiler/nir/nir_validate.c
View file

@ -930,6 +930,14 @@ validate_tex_instr(nir_tex_instr *instr, validate_state *state)
}
}
bool msaa = (instr->sampler_dim == GLSL_SAMPLER_DIM_MS ||
instr->sampler_dim == GLSL_SAMPLER_DIM_SUBPASS_MS);
if (msaa)
validate_assert(state, instr->op != nir_texop_txf);
else
validate_assert(state, instr->op != nir_texop_txf_ms);
if (instr->op != nir_texop_tg4)
validate_assert(state, instr->component == 0);