From e7a035df653f1135cfffbbe152f0ae69beeec3b4 Mon Sep 17 00:00:00 2001 From: Georg Lehmann Date: Mon, 11 May 2026 14:55:25 +0200 Subject: [PATCH] radv: fix amount of sample shading with required sample shaded inputs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Vulkan spec says: If a fragment shader entry point statically uses an input variable decorated with a BuiltIn of SampleId or SamplePosition, sample shading is enabled and a value of 1.0 is used instead of minSampleShading. If a fragment shader entry point statically uses an input variable decorated with Sample, sample shading may be enabled and a value of 1.0 will be used instead of minSampleShading if it is. This means we have to overwrite the command buffer state entirely. Cc: mesa-stable Reviewed-by: Samuel Pitoiset Reviewed-by: Marek Olšák Part-of: --- src/amd/vulkan/radv_cmd_buffer.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index e3a05385cda..5b55e3b8e91 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -1998,13 +1998,19 @@ radv_is_sample_shading_enabled(struct radv_cmd_buffer *cmd_buffer, float *min_sa if (min_sample_shading) *min_sample_shading = 1.0f; + /* If the PS requires sample shading for inputs, + * min_sample_shading is overwritten to 1.0. + */ + if (ps && ps->info.ps.uses_sample_shading) + return true; + if (cmd_buffer->state.ms.sample_shading_enable) { if (min_sample_shading) *min_sample_shading = cmd_buffer->state.ms.min_sample_shading; return true; } - return ps ? ps->info.ps.uses_sample_shading : false; + return false; } static ALWAYS_INLINE unsigned