From e714e2f88d5a38a3db266581422f36020ca7d91f Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 2 Apr 2025 09:41:28 +0200 Subject: [PATCH] panfrost: enable ARB_texture_query_lod on v9+ We've been reporting in features.txt that we support this extension unconditionally, but we didn't. Now that we have the bits wired up due to Vulkan, we can actually enable it on Bifrost and later. Reviewed-by: Iago Toral Quiroga Reviewed-by: Lars-Ivar Hesselberg Simonsen Reviewed-by: Lorenzo Rossi Part-of: --- docs/features.txt | 2 +- docs/relnotes/new_features.txt | 1 + src/gallium/drivers/panfrost/pan_screen.c | 1 + src/panfrost/ci/panfrost-g57-gles2-extensions.txt | 1 + src/panfrost/ci/panfrost-g610-gles2-extensions.txt | 1 + 5 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 29197179949..3378cad8fea 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -135,7 +135,7 @@ GL 4.0, GLSL 4.00 --- all DONE: freedreno/a6xx, nvc0, r600, radeonsi, llvmpipe, GL_ARB_texture_buffer_object_rgb32 DONE (freedreno, softpipe, panfrost, crocus/gen6+) GL_ARB_texture_cube_map_array DONE (freedreno/a4xx+, nv50, softpipe, v3d, panfrost, crocus/gen6+) GL_ARB_texture_gather DONE (freedreno, nv50, softpipe, v3d, panfrost) - GL_ARB_texture_query_lod DONE (freedreno, nv50, softpipe, v3d, panfrost, crocus/gen5+) + GL_ARB_texture_query_lod DONE (freedreno, nv50, softpipe, v3d, panfrost/v9+, crocus/gen5+) GL_ARB_transform_feedback2 DONE (freedreno/a3xx+, nv50, softpipe, v3d, panfrost, crocus/gen6+) GL_ARB_transform_feedback3 DONE (freedreno/a3xx+, softpipe, panfrost) diff --git a/docs/relnotes/new_features.txt b/docs/relnotes/new_features.txt index 81c666f1278..05c6bfcbb27 100644 --- a/docs/relnotes/new_features.txt +++ b/docs/relnotes/new_features.txt @@ -10,3 +10,4 @@ shaderImageGatherExtended on pvr static C++ stdlib required on rusticl to workaround applications using their own C++ stdlib VK_EXT_pipeline_protected_access on RADV VK_EXT_extended_dynamic_state3 on panvk +GL_ARB_texture_query_lod on panfrost/v9+ diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c index 86d28d2de7a..af4cc7106db 100644 --- a/src/gallium/drivers/panfrost/pan_screen.c +++ b/src/gallium/drivers/panfrost/pan_screen.c @@ -690,6 +690,7 @@ panfrost_init_screen_caps(struct panfrost_screen *screen) caps->depth_clip_disable = true; caps->mixed_framebuffer_sizes = true; caps->frontend_noop = true; + caps->texture_query_lod = dev->arch >= 9; caps->sample_shading = dev->arch >= 6; caps->fragment_shader_derivatives = true; caps->framebuffer_no_attachment = true; diff --git a/src/panfrost/ci/panfrost-g57-gles2-extensions.txt b/src/panfrost/ci/panfrost-g57-gles2-extensions.txt index c684b25453f..056c3653dbd 100644 --- a/src/panfrost/ci/panfrost-g57-gles2-extensions.txt +++ b/src/panfrost/ci/panfrost-g57-gles2-extensions.txt @@ -62,6 +62,7 @@ GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_mirror_clamp_to_edge GL_EXT_texture_norm16 +GL_EXT_texture_query_lod GL_EXT_texture_rg GL_EXT_texture_sRGB_decode GL_EXT_texture_sRGB_R8 diff --git a/src/panfrost/ci/panfrost-g610-gles2-extensions.txt b/src/panfrost/ci/panfrost-g610-gles2-extensions.txt index c684b25453f..056c3653dbd 100644 --- a/src/panfrost/ci/panfrost-g610-gles2-extensions.txt +++ b/src/panfrost/ci/panfrost-g610-gles2-extensions.txt @@ -62,6 +62,7 @@ GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_mirror_clamp_to_edge GL_EXT_texture_norm16 +GL_EXT_texture_query_lod GL_EXT_texture_rg GL_EXT_texture_sRGB_decode GL_EXT_texture_sRGB_R8