fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-06 03:30:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

clc: remove check for null pointer that cannot be true in llvm_mod_to_spirv

Browse source 
Snce the *args parameter was added it's assumed to be non-null. If it is
null then the function is going off to UB land. As such, a later check
added for args being NULL is useless, and confuses coverity.

fixes: 3a752256f5

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29664>
This commit is contained in:
Dylan Baker 2024-06-10 13:45:50 -07:00 • committed by Marge Bot
parent 9fa310b876
commit e67a8dc59a
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/compiler/clc/clc_helpers.cpp
View file

@ -1039,9 +1039,7 @@ llvm_mod_to_spirv(std::unique_ptr<::llvm::Module> mod,
return -1;
}
const char *const *extensions = NULL;
if (args)
extensions = args->allowed_spirv_extensions;
const char *const *extensions = args->allowed_spirv_extensions;
if (!extensions) {
/* The SPIR-V parser doesn't handle all extensions */
static const char *default_extensions[] = {