pan: Drop bifrost_shader_blend_info::format

It existed entirey to save us a switch statement.  It's very unlikely
that's worth pulling GENX API command stream stuff into the compiler.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38788>
This commit is contained in:
Faith Ekstrand 2025-12-03 11:34:28 -05:00 committed by Marge Bot
parent 3970548556
commit e64736fba7
4 changed files with 3 additions and 15 deletions

View file

@ -411,7 +411,7 @@ panfrost_emit_blend(struct panfrost_batch *batch, void *rts,
pan_fixup_blend_type)(fs->info.bifrost.blend[i].type, format);
} else {
cfg.fixed_function.conversion.register_format =
fs->info.bifrost.blend[i].format;
pan_blend_type_from_nir(fs->info.bifrost.blend[i].type);
}
#endif
}

View file

@ -179,9 +179,6 @@ pan_get_fixed_varying_mask(unsigned varyings_used)
struct bifrost_shader_blend_info {
nir_alu_type type;
uint32_t return_offset;
/* mali_bifrost_register_file_format corresponding to nir_alu_type */
unsigned format;
};
/*

View file

@ -170,12 +170,4 @@ pan_shader_compile(nir_shader *s, struct pan_compile_inputs *inputs,
info->ftz_fp32 = true;
}
}
if (arch >= 6) {
/* This is "redundant" information, but is needed in a draw-time hot path */
for (unsigned i = 0; i < ARRAY_SIZE(info->bifrost.blend); ++i) {
info->bifrost.blend[i].format =
pan_blend_type_from_nir(info->bifrost.blend[i].type);
}
}
}

View file

@ -196,14 +196,13 @@ emit_blend_desc(const struct pan_shader_info *fs_info, uint64_t fs_code,
cfg.internal.fixed_function.rt = rt_idx;
#if PAN_ARCH < 9
nir_alu_type type = fs_info->bifrost.blend[blend_idx].type;
if (fs_info->fs.untyped_color_outputs) {
nir_alu_type type = fs_info->bifrost.blend[blend_idx].type;
cfg.internal.fixed_function.conversion.register_format =
GENX(pan_fixup_blend_type)(type, rt->format);
} else {
cfg.internal.fixed_function.conversion.register_format =
fs_info->bifrost.blend[blend_idx].format;
pan_blend_type_from_nir(type);
}
if (!opaque) {