fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 09:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

freedreno: Check file descriptor before write.

Browse source 
Fix defect reported by Coverity Scan.

Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: fd is passed to a parameter that cannot be
negative.

Fixes: 1ea4ef0d3b ("freedreno: slurp in decode tools")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6696>
This commit is contained in:
Vinson Lee 2020-09-11 16:00:07 -07:00 • committed by Marge Bot
parent 50f1cd4076
commit e607477d7c
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/freedreno/decode/cffdec.c
View file

@ -403,8 +403,10 @@ dump_shader(const char *ext, void *buf, int bufsz)
int fd;
sprintf(filename, "%04d.%s", n++, ext);
fd = open(filename, O_WRONLY| O_TRUNC | O_CREAT, 0644);
write(fd, buf, bufsz);
close(fd);
if (fd != -1) {
write(fd, buf, bufsz);
close(fd);
}
}
}