fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 00:38:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

tu/kgsl: Better detection of sparse support

Browse source 
Apparently a device can support KGSL_MEMFLAGS_VBO but not
IOCTL_KGSL_GPUMEM_BIND_RANGES or IOCTL_KGSL_GPU_AUX_COMMAND.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/15006
Fixes: 71ef46717c ("tu/kgsl: Add support for sparse binding")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
(cherry picked from commit f23e88108d)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40488>
This commit is contained in:
Danylo Piliaiev 2026-03-13 18:23:39 +01:00 • committed by Eric Engestrom
parent 976efbe12a
commit e5f61543fe
2 changed files with 47 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -154,7 +154,7 @@
"description": "tu/kgsl: Better detection of sparse support",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "71ef46717cd091f0a12a12cf5a8da3ec8a6fe96a",
"notes": null

52
src/freedreno/vulkan/tu_knl_kgsl.cc
View file

@ -565,21 +565,61 @@ kgsl_is_memory_type_supported(int fd, uint32_t flags)
static bool
kgsl_is_virtual_bo_supported(int fd)
{
struct kgsl_gpuobj_alloc req_alloc = {
.size = 0x1000,
bool supported = false;
struct kgsl_gpuobj_alloc req_alloc_parent = {
.size = 0x2000,
.flags = KGSL_MEMFLAGS_VBO,
};
struct kgsl_gpumem_alloc_id req_alloc_child = {
.size = 0x1000,
};
struct kgsl_gpumem_bind_range req_range = {};
struct kgsl_gpumem_bind_ranges req_ranges = {};
struct kgsl_gpumem_free_id req_free_child = {};
struct kgsl_gpuobj_free req_free_parent = {};
int ret = safe_ioctl(fd, IOCTL_KGSL_GPUOBJ_ALLOC, &req_alloc);
int ret = safe_ioctl(fd, IOCTL_KGSL_GPUOBJ_ALLOC, &req_alloc_parent);
if (ret) {
return false;
}
struct kgsl_gpuobj_free req_free = { .id = req_alloc.id };
ret = safe_ioctl(fd, IOCTL_KGSL_GPUMEM_ALLOC_ID, &req_alloc_child);
if (ret) {
goto free_parent;
}
safe_ioctl(fd, IOCTL_KGSL_GPUOBJ_FREE, &req_free);
req_range = {
.child_offset = 0,
.target_offset = 0,
.length = 0x1000,
.child_id = req_alloc_child.id,
.op = KGSL_GPUMEM_RANGE_OP_BIND,
};
return true;
req_ranges = {
.ranges = (uint64_t) (uintptr_t) &req_range,
.ranges_nents = 1,
.ranges_size = sizeof(req_range),
.id = req_alloc_parent.id,
.flags = 0,
};
ret = safe_ioctl(fd, IOCTL_KGSL_GPUMEM_BIND_RANGES, &req_ranges);
if (ret) {
goto free_child;
}
supported = true;
free_child:
req_free_child = { .id = req_alloc_child.id };
safe_ioctl(fd, IOCTL_KGSL_GPUMEM_FREE_ID, &req_free_child);
free_parent:
req_free_parent = { .id = req_alloc_parent.id };
safe_ioctl(fd, IOCTL_KGSL_GPUOBJ_FREE, &req_free_parent);
return supported;
}
enum kgsl_syncobj_state {